Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for python 2.7 and cli parameters #1712

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix for python 2.7 and cli parameters #1712

merged 2 commits into from
Oct 9, 2019

Conversation

brynne8
Copy link
Contributor

@brynne8 brynne8 commented Sep 30, 2019

Description

  • raise Exception instead of string to avoid error in python 2.7
  • set io encoding to UTF-8, as our code is often UTF-8, instead of same as system default.
  • added or corrected command line option names per readme.

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

@bitwiseman bitwiseman added this to the v1.10.x milestone Oct 9, 2019
@bitwiseman bitwiseman merged commit 45b073d into beautifier:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
implementation: python type: bug
Projects
None yet
Milestone
v1.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@brynne8 @bitwiseman